Open
Conversation
… impurity densities
…es in plasma profiles
…g and improve readability
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4118 +/- ##
==========================================
- Coverage 47.26% 47.20% -0.06%
==========================================
Files 139 139
Lines 29420 29457 +37
==========================================
Hits 13906 13906
- Misses 15514 15551 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request significantly refactors the density profile plotting logic in
plot_proc.pyto improve clarity, modularity, and the visualization of impurity species. The main changes include splitting the density and impurity plots into separate subplots, dynamically handling impurity species, improving axis scaling (including log scale for impurity densities), and updating subplot arrangements and annotations for better presentation.Key changes:
Density and Impurity Profile Plotting Improvements
plot_n_profilesto use two subplots: one for main plasma densities and another for impurity densities, each with appropriate axis labels, legends, and units. Impurity densities are now plotted in units of 1e16 m⁻³ and can use a logarithmic y-axis if the data spans several orders of magnitude.Profile Calculation and Data Handling
Plot Layout and Annotation Updates
main_plotto accommodate the new density/impurity subplot split and to improve overall figure layout.Data Output Enhancement
outplasmethod inphysics.pyto output impurity electron densities at each profile point when present, supporting more detailed diagnostics and post-processing.Checklist
I confirm that I have completed the following checks: