Fix PureConc async cancelation#4624
Open
djspiewak wants to merge 6 commits into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3430
I'll probably rebase this forward to 3.6 or something but I'm opening it like this as a hilarious testament to how long this took.
There are a lot of interesting things in this PR, since the root cause is just the fact that async cancelation is fundamentally different than the busy-check
flatMapinterruption. The most interesting bit tbh is the fact that I wasn't able to solve all of this myself. I got most of it working, but ultimately hit a wall which was essentially beyond my ability to debug about six months ago. Or rather, I probably could have worked my way through it, but it was incredibly tedious and complicated.I've been using this branch as a testbed for the frontier agentic systems for a while now, since it's quite a novel bit of code with essentially zero precedent in kind, and as expected all of them failed spectacularly and almost immediately until my most recent effort. The commits you see from the past few days were generated by GPT 5.5 (xhigh). I would guess that Opus 4.8 and GLM 5.2 would do similarly well but haven't attempted it.
If anyone wants to play around with replicating this result, the prompt I used was the following:
This was based on a dirty working directory which had half of
HEAD^but nothing super relevant iirc (I can dig out the exact state if anyone is really interested in replication).