chore: bump SDK to v6.0.0 + migrate Config access through GetConfig#546
chore: bump SDK to v6.0.0 + migrate Config access through GetConfig#546kaidaguerre wants to merge 2 commits into
Conversation
Migrates connection.Config direct reads to connection.GetConfig() per steampipe-plugin-sdk v6.0.0. The SDK now guards Connection.Config under a per-connection sync.RWMutex (see steampipe-plugin-sdk#938) — direct field reads from worker goroutines would race with the SDK's in-place mutation during credential rotation. The github plugin's appendUserInteractionAbilityForIssue at user_utils.go is the highest-traffic read site (called unconditionally on every query to 7+ tables, no cache), so this migration closes a particularly active race surface. Bumps go directive to 1.26 (required by SDK v6).
|
Closing — this PR does not fix a customer-visible bug. Cross-checking the v6 SDK race fix against this plugin's auth model: Pipes does NOT push rotated credentials into the github plugin's connection config. GitHub auth uses either The CHANGELOG bug-fix narrative claiming For context, see turbot/steampipe-plugin-aws#2756 — the actual rotation fix adds a custom If a pure dependency-hygiene bump becomes desirable later, a new PR with a |
1 participant
Migrates
connection.Configdirect reads toconnection.GetConfig()persteampipe-plugin-sdkv6.0.0 (see steampipe-plugin-sdk#938). GitHub-side rollout of the same fix that landed for AWS in steampipe-plugin-aws#2756. The github plugin had the highest-traffic uncachedconnection.Configread site of any plugin sampled (appendUserInteractionAbilityForIssueinuser_utils.go, called per-query on 7+ tables) — this PR closes that race surface. Build, vet, test, andgo test -raceall green.