Skip to content

Conversation

@D-K-P
Copy link
Member

@D-K-P D-K-P commented Feb 11, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2026

⚠️ No Changeset found

Latest commit: 2810779

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Walkthrough

The Cursor CLI build extension setup has been refactored to change the export pattern from a pre-defined extension object to a function that returns a BuildExtension. A module-level CURSOR_AGENT_DIR constant is introduced to define the target path for the agent binary. The onBuildComplete handler now includes build-time gating to skip execution when the target is "dev". The build layer logic is restructured to install runtime dependencies, update PATH, execute the official Cursor installer, and copy the resulting binary to CURSOR_AGENT_DIR, replacing the previous direct COPY and CHMOD approach. Internal function parameters are renamed from params to context.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is missing nearly all required template sections including testing details, changelog, and checklist items. Only a Devin review badge is present. Add required sections: fill out the checklist, describe testing steps, provide a changelog summary, and remove the auto-generated badge. Follow the repository's description template completely.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: cursor cli docs update (remove chmod workaround)' accurately describes the main change of removing a chmod workaround in the Cursor CLI documentation/build setup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor-cli-docs-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@D-K-P D-K-P merged commit 6e3ac8b into main Feb 11, 2026
9 of 10 checks passed
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/guides/example-projects/cursor-background-agent.mdx (1)

63-84: ⚠️ Potential issue | 🟡 Minor

Include the missing BuildExtension import with correct package path.

The snippet references BuildExtension on line 66 but doesn't show the import. Add this to the top of the code block:

Missing import
import type { BuildExtension } from "@trigger.dev/build";

Additionally, note that cursorCli is now a factory function—it must be called as cursorCli() (not cursorCli) when adding it to the extensions array in trigger.config.ts. The linked GitHub repo (line 109) shows the correct usage pattern.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 170fde3 and 2810779.

📒 Files selected for processing (1)
  • docs/guides/example-projects/cursor-background-agent.mdx
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Use build extensions in trigger.config.ts (additionalFiles, additionalPackages, aptGet, prismaExtension, etc.) to customize the build
📚 Learning: 2025-11-27T16:27:35.304Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Use build extensions in trigger.config.ts (additionalFiles, additionalPackages, aptGet, prismaExtension, etc.) to customize the build

Applied to files:

  • docs/guides/example-projects/cursor-background-agent.mdx
🔇 Additional comments (2)
docs/guides/example-projects/cursor-background-agent.mdx (2)

61-61: LGTM! The updated description accurately reflects the new build approach — running the official installer at build time and copying the resolved binary to a fixed path.


68-69: Good addition: dev-target gating. Skipping the layer installation during dev builds avoids unnecessary work in local development. Clean implementation.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@D-K-P D-K-P deleted the cursor-cli-docs-update branch February 11, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants