Fix: Optimize Pancake Sort visiting callback count and fix failing tests#2099
Open
nirvagold wants to merge 3 commits intotrekhleb:masterfrom
Open
Fix: Optimize Pancake Sort visiting callback count and fix failing tests#2099nirvagold wants to merge 3 commits intotrekhleb:masterfrom
nirvagold wants to merge 3 commits intotrekhleb:masterfrom
Conversation
- Remove unnecessary visitingCallback calls in flip() method - Optimize findMaxIndex() to start from index 1 instead of 0 - Update test complexity constants to match optimized implementation - Add eslint-disable for no-param-reassign following project conventions - All 7 tests now passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary visitingCallback calls in flip() method
Optimize findMaxIndex() to start from index 1 instead of 0
Update test complexity constants to match optimized implementation
Add eslint-disable for no-param-reassign following project conventions
All 7 tests now passing