Skip to content

activity string is at MotionActivityEvent.type#1335

Open
chrisdrackett wants to merge 1 commit into
transistorsoft:masterfrom
chrisdrackett:patch-1
Open

activity string is at MotionActivityEvent.type#1335
chrisdrackett wants to merge 1 commit into
transistorsoft:masterfrom
chrisdrackett:patch-1

Conversation

@chrisdrackett

Copy link
Copy Markdown

No description provided.

@oliverdolgener oliverdolgener left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@Wunsz

Wunsz commented Aug 16, 2022

Copy link
Copy Markdown

Why not set the actual types instead of string?

 'still' | 'on_foot' | 'walking' | 'running' | 'in_vehicle' | 'on_bicycle'

I raised my own PR that changes both erros:
#1524

@tsachit

tsachit commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

any update here?

@david-gettins

Copy link
Copy Markdown

There hasn't been any movement on this since August last year so I took the liberty of creating a new PR that resolves the union type comment. Please see #1624.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants