feat(together): add finish_reason attribute to spans#4136
feat(together): add finish_reason attribute to spans#4136raghavenderreddygrudhanti wants to merge 2 commits into
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR captures the model response finish reason into the span as ChangesResponse finish reason tracking
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
raghavenderreddygrudhanti
left a comment
There was a problem hiding this comment.
Looks good overall. The GEN_AI_RESPONSE_FINISH_REASON attribute is being set safely with a fallback when response.choices is unavailable. I reviewed the implementation and validation layer.
Reviewed in CodeRabbit Review Stack
What
Adds
gen_ai.response.finish_reasonattribute to Together AI spans.Why
Other instrumentations (OpenAI, Anthropic, Groq) already capture this attribute. It's useful for monitoring stop reasons (eos, length, stop) and alerting on unexpected truncations.
Changes
span_utils.pytest_chat.pySummary by CodeRabbit
Bug Fixes
Tests
Documentation