Open
Conversation
titaniumbones
requested changes
Oct 4, 2017
Owner
titaniumbones
left a comment
titaniumbones
left a comment
There was a problem hiding this comment.
Overall, this is a good start, but still needs a little work before it's done -- see my comments inline!
|
|
||
| So you could add more contexts to your website. | ||
|
|
||
| ## What is a HTML5 Video? |
Owner
There was a problem hiding this comment.
try to correct small erros like "a", which should be "an" here.
|
|
||
| ``` html | ||
| <iframe width="854" height="480" src="https://www.youtube.com/embed/LSxElWwWVFE" frameborder="0" allowfullscreen></iframe> | ||
| ``` |
Owner
There was a problem hiding this comment.
If you're going to use this embed ode, you should at least explain what it is. And some more details about why a YouTube video is difficult to add using <video> would really enhance this tutorial quite a bit!
| <source src="http://www.noiseaddicts.com/samples_1w72b820/4033.mp3" type="video/mp4"> | ||
| </audio> | ||
|
|
||
| <p> Try it out on <a href=https://jsbin.com/?output>Jsbin<a/>.</p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.