Open
Conversation
Owner
|
Hi Diane, As it stands the tutorial doesn't seem to work, I think because your css selector doens't address the image! also --maybe your tutorial can give a few more hints about what specific steps the user should attempt in order to get the desired effect? |
Author
|
I will work to fix it. I ran it several times before I submitted it and it worked. |
Owner
|
I wonder if some of your changes didn't get committed or something. The
code I'm seeing probably would never have worked...
dpammyb <notifications@github.com> writes:
… I will work to fix it. I ran it several times before I submitted it and it worked.
Re: specific steps, I was not sure how much detail to put. I felt I needed to address containers and margins and padding but then thought it would look like a toutorial about a few things instead of one. I should have checked with you. Thanks for the feed back.
Please clarify: Are you are giving me the opportunity to fix this or are you just explaining why I failed this assignment?
--
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed a tag to flaot property