-
Notifications
You must be signed in to change notification settings - Fork 220
DOC-3355: While the plugin is generating a review or quick action, the Stop button in the loading indicator receives focus #4079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kemister85
wants to merge
1
commit into
feature/8.5.0/DOC-3355
Choose a base branch
from
feature/8.5.0/DOC-3355_TINY-14083
base: feature/8.5.0/DOC-3355
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -42,6 +42,22 @@ The {productname} {release-version} release includes an accompanying release of | |||||
| For information on the **<Premium plugin name 1>** plugin, see: xref:<plugincode>.adoc[<Premium plugin name 1>]. | ||||||
|
|
||||||
|
|
||||||
| === TinyMCE AI | ||||||
|
|
||||||
| The {productname} {release-version} release includes an accompanying release of the **TinyMCE AI** premium plugin. | ||||||
|
|
||||||
| **TinyMCE AI** includes the following improvement. | ||||||
|
|
||||||
| ==== While the plugin is generating a review or quick action, the Stop button in the loading indicator receives focus | ||||||
| // #TINY-14083 | ||||||
|
|
||||||
| Previously, the TinyMCE AI plugin displayed the stop generating button inconsistently across different contexts. The review loading indicator used a text-based "Stop generating" button, while the AI Chat sidebar used a stop icon button. Additionally, the button did not receive focus when displayed, which compromised keyboard accessibility. | ||||||
|
|
||||||
| In {productname} {release-version}, the stop button in the loading indicator now matches the icon button used in the AI Chat sidebar, providing a consistent visual experience. The button also receives immediate focus when displayed, improving keyboard navigation and accessibility during content generation. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| For information on the **TinyMCE AI** plugin, see: xref:tinymceai.adoc[TinyMCE AI]. | ||||||
|
|
||||||
|
|
||||||
| [[accompanying-enhanced-skins-and-icon-packs-changes]] | ||||||
| == Accompanying Enhanced Skins & Icon Packs changes | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.