compiler: consistently pass layout and alignment to createAlloc#5509
Open
niaow wants to merge 1 commit into
Open
compiler: consistently pass layout and alignment to createAlloc#5509niaow wants to merge 1 commit into
niaow wants to merge 1 commit into
Conversation
deadprogram
reviewed
Jul 16, 2026
|
|
||
| // Make the runtime call. | ||
| call := b.createRuntimeCall(allocFunc, []llvm.Value{sizeValue, layoutValue}, comment) | ||
| if align != 0 { |
Member
There was a problem hiding this comment.
After this change, passing align=0 to createAlloc would produce an align 0 LLVM attribute, which is invalid in LLVM IR (alignment must be a power of 2 or omitted). The PR assumes all callsites are fixed, but if any future callsite passes 0, it would produce broken IR silently. Consider adding an assertion/panic if align == 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the
// TODO: make sure all callsites set the correct alignment.from #5420 as well as some places where we did not pass the object layout.