Benchmark error fix and 0.42.0 additions#19
Open
soypat wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
I've provided fixes for the microbenchmarking. Here are the results. Before:
After
|
Member
|
Update to use most recent Go 1.26.x please. Otherwise looks good to me. |
Collaborator
Author
|
@deadprogram I can't build tinygo with go 1.26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue with the
resultsdirectory not having a ending underscore to exclude it from search of benchmark corpus. Also the error branches were inverted. It also adds 0.42.0 benchmark results. We should include the text file in results going forwardBenchmarks are starting to look a little wonky after @juhotuho10 fixes. We should at the very least remove fannkuch-reduc-args=6, maybe even args=7 since the time it takes to run is way too little and it just completely throws other plots off axis.