fix: Darwin services ordering in DiscoverServices#417
Open
acouvreur wants to merge 2 commits intotinygo-org:devfrom
Open
fix: Darwin services ordering in DiscoverServices#417acouvreur wants to merge 2 commits intotinygo-org:devfrom
acouvreur wants to merge 2 commits intotinygo-org:devfrom
Conversation
The services will now appear on the expected order
Author
|
@deadprogram @jagobagascon review when you can please Thanks a lot 👍 @jagobagascon I've pinged you even though you were only mentioned on Windows reviews, but the change is basically the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The services will now appear on the expected order
Closes #416
Similar to #409 and its #410 pull request
Similar to #414 and its #415 pull request