*: detecting abrupt disconnections in Linux#408
Open
sorayaormazabalmayo wants to merge 1 commit intotinygo-org:devfrom
Open
*: detecting abrupt disconnections in Linux#408sorayaormazabalmayo wants to merge 1 commit intotinygo-org:devfrom
sorayaormazabalmayo wants to merge 1 commit intotinygo-org:devfrom
Conversation
sorayaormazabalmayo
force-pushed
the
feature/abrupt-disconnection-linux
branch
2 times, most recently
from
904e54e to
2818558
Compare
deadprogram
reviewed
Feb 25, 2026
| } | ||
|
|
||
| a.monitoringConnections = true | ||
| go a.handleConnectionSignals() |
Member
There was a problem hiding this comment.
@sorayaormazabalmayo I think there needs to be a way to stop this goroutine cleanly on exit.
Author
There was a problem hiding this comment.
You are right @deadprogram! I have just added StopConnectionMonitoring that unregisters the D-Bus signal handlers, closes channels, and sets monitoringConnections to false. Also, the select loop in handleConnectionSignals listens on stopMonitorChan so the goroutine exits immediately on shutdown.
sorayaormazabalmayo
force-pushed
the
feature/abrupt-disconnection-linux
branch
from
2818558 to
8455a42
Compare
This PR implements persistent D-Bus signal monitoring at the adapter level to detect abrupt disconnections. The `connectHandler` callback was not being invoked when Bluetooth devices disconnected abruptly (e.g., device powered off, out of range, battery died) on Linux. It only worked for planned disconnections via `Device.Disconnect()`. This created an inconsistency with the Darwin implementation, which correctly detects all disconnections through CoreBluetooth's `DidDisconnectPeripheral` delegate method.
sorayaormazabalmayo
force-pushed
the
feature/abrupt-disconnection-linux
branch
from
8455a42 to
196598c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements persistent D-Bus signal monitoring at the adapter level to detect abrupt disconnections. The
connectHandlercallback was not being invoked when Bluetooth devices disconnected abruptly (e.g., device powered off, out of range, battery died) on Linux. It only worked for planned disconnections viaDevice.Disconnect(). This created an inconsistency with the Darwin implementation, which correctly detects all disconnections through CoreBluetooth'sDidDisconnectPeripheraldelegate method.