MNT: Update internal usages of privatized Formatter attributes in ticker.py#39
Merged
timhoffm merged 1 commit intotimhoffm:mnt-deprecate-formatter-attrsfrom Apr 11, 2026
Conversation
buddy0452004
force-pushed
the
mnt-deprecate-formatter-attrs
branch
from
57322fb to
5111092
Compare
buddy0452004
force-pushed
the
mnt-deprecate-formatter-attrs
branch
from
5111092 to
93a5856
Compare
timhoffm
approved these changes
Apr 11, 2026
timhoffm
merged commit 46ee6ca
into
timhoffm:mnt-deprecate-formatter-attrs
3 checks passed
Owner
|
Thanks @buddy0452004 ! |
Author
|
Happy to help! Let me know if there's anything else I can contribute to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up contribution to matplotlib#31416.
The internal usages of
locs,orderOfMagnitude, andformatinticker.pywere still referencing the old public attribute names, causing the tests to fail. This commit updates all of them to use the private names (_locs,_orderOfMagnitude,_format) acrossScalarFormatter,LogitFormatter,EngFormatter, andPercentFormatter.sankey.pywas not changed since itsformatattribute belongs to a completely different class.Works towards matplotlib#31396.
PR checklist