Open
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
wraithgar
added a commit
to wraithgar/node-promise-retry
that referenced
this pull request
Feb 25, 2026
This wasn't tested, and would have looped forever trying to populate this.#timeouts Originally from: tim-kos/node-retry#77
wraithgar
added a commit
to wraithgar/node-promise-retry
that referenced
this pull request
Feb 25, 2026
This wasn't tested, and would have looped forever trying to populate this.#timeouts Originally from: tim-kos/node-retry#77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped into a problem where when passing
Infinityas an value for theretriesoption, it will result into a memory heap overload when it tries to create the array of timeouts. It seems like this option is supposed to be supported. This PR is my proposition on how this could be fixed.