Conversation
thomhurst
added
dependencies
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.29
This is a straightforward Renovate Bot dependency bump for three TUnit packages:
TUnit1.17.25 → 1.17.29TUnit.Assertions1.17.25 → 1.17.29TUnit.Core1.17.25 → 1.17.29
Assessment: Looks good ✓
The update is clean and well-structured:
- All three TUnit packages are kept in sync at the same version (1.17.29), which is correct as they are part of the same framework and should always be updated together.
- The change is confined to
Directory.Packages.props, which is the correct centralized location for managing NuGet package versions in this repo. - The TUnit 1.17.29 release notes indicate minor additions (span return support in mocks) and internal refactoring — no breaking changes noted.
- Codacy, CodeFactor, and Snyk checks are all passing for this PR.
No concerns. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
9cadd33 to
d05b536
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.36
This is a Renovate Bot dependency bump for three TUnit packages:
TUnit1.17.25 → 1.17.36TUnit.Assertions1.17.25 → 1.17.36TUnit.Core1.17.25 → 1.17.36
Note on Previous Review: A previous review was posted when the target was 1.17.29. The PR has since been rebased/updated to target 1.17.36. This review covers the full range.
Assessment: Looks good ✓
The update is clean and correct:
- Version consistency: All three TUnit packages remain in sync at 1.17.36, which is required — they are part of the same framework and must always be updated together.
- Correct location: Changes are confined to
Directory.Packages.props, the centralized package version management file. Individual.csprojfiles don't need to be touched. - Changelog highlights (1.17.25 → 1.17.36):
- Mock API improvements: concise inline lambda API, untyped
Any(), span return.Returns()support - Refactoring of Mock control members to static helpers
- Internal dependency updates (no breaking changes noted)
- Mock API improvements: concise inline lambda API, untyped
- The changes are purely additive/refinements in the mocking API — no breaking changes that would affect this repo's test suite.
No architectural concerns. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
d05b536 to
1a00dcb
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.54
This is a Renovate Bot dependency bump for three TUnit packages (the PR has been rebased/updated again since prior reviews at 1.17.29 and 1.17.36):
TUnit1.17.25 → 1.17.54TUnit.Assertions1.17.25 → 1.17.54TUnit.Core1.17.25 → 1.17.54
Assessment: Looks good
The change is correct and well-structured:
- Version consistency: All three TUnit packages are kept in sync at the same version (1.17.54). Since
TUnit,TUnit.Assertions, andTUnit.Coreare part of the same framework and share internal coupling, keeping them at the same version is required to avoid unexpected runtime or compilation errors. - Correct location: The change is confined to
Directory.Packages.props, which is the right centralized place for NuGet version management in this repo. No individual.csprojfiles need modification, which is the expected pattern when using Central Package Management (CPM). - Changelog highlights (1.17.36 → 1.17.54):
- New assertions:
IsAssignableFrom<T>()andIsNotAssignableFrom<T>()added to the assertions API — purely additive. - Bug fix: GitHub reporter summary newline fix for improved rendering.
- Documentation restructuring — no behavioral changes.
- No breaking changes noted across any of the intermediate releases.
- New assertions:
Since these changes are purely additive (new assertions) plus a minor bug fix, and no breaking changes are indicated, there is no risk of existing tests in this repo being disrupted by the update.
No concerns. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
1a00dcb to
b6e9e16
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.54 (Follow-up)
This PR continues to show the same clean dependency bump as covered in the previous reviews. The current diff remains identical to what was reviewed on 2026-02-27:
TUnit1.17.25 → 1.17.54TUnit.Assertions1.17.25 → 1.17.54TUnit.Core1.17.25 → 1.17.54
Previous Reviews: Addressed ✓
All previous review points remain valid and there are no new concerns:
- Version consistency: All three packages remain in sync at 1.17.54 — correct.
- Correct location: Change confined to
Directory.Packages.props(Central Package Management) — correct. - No breaking changes: The intermediate releases (1.17.25 → 1.17.54) include only additive features (new assertions
IsAssignableFrom<T>/IsNotAssignableFrom<T>()), a minor GitHub reporter rendering fix, and documentation updates.
CI Status
CI pipelines are currently pending. CodeFactor and Snyk are already passing with no issues.
No concerns with the code change itself. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
b6e9e16 to
5888ba9
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: TUnit 1.17.25 → 1.18.0 Dependency Update
This is a straightforward dependency update generated by Renovate bot, bumping all three TUnit packages (TUnit, TUnit.Assertions, TUnit.Core) from 1.17.25 to 1.18.0 in Directory.Packages.props.
Summary of Changes
The diff is minimal and correct — a version bump in a single file using the centralized package management pattern (Directory.Packages.props). All three packages are kept in sync at the same version, which is the right approach.
Notable improvements in TUnit 1.18.0
- Performance: Test metadata creation is now fully synchronous, with significant JIT compilation reductions (~18,000–27,000 fewer JITs), which should benefit test startup time in this project.
- Bug fix:
IsEquivalentTonow correctly falls back toEquals()for types with no public members — this could silently fix edge-case assertion behavior in existing tests. - New feature: Rich HTML test reports are now available (opt-in), which may be useful to consider for CI reporting.
- Refactor: 15 manual assertions converted to
[GenerateAssertion]— internal cleanup that shouldn't affect consumers.
Assessment
No issues found. The update is safe, well-scoped, and the confidence rating from Renovate is expected to be high for a minor version bump from the same author (thomhurst) who maintains both this repo and TUnit. Auto-merge is appropriately enabled for this kind of routine maintenance PR.
thomhurst
force-pushed
the
renovate/tunit
branch
from
5888ba9 to
a2214e9
Compare
thomhurst
changed the title
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
There was a problem hiding this comment.
Code Review: TUnit 1.17.25 → 1.18.9 Dependency Update
This PR (updated by Renovate bot) bumps all three TUnit packages in Directory.Packages.props:
TUnit1.17.25 → 1.18.9TUnit.Assertions1.17.25 → 1.18.9TUnit.Core1.17.25 → 1.18.9
Previous Reviews: Addressed ✓
Previous reviews covered this PR through version 1.18.0. No prior concerns were raised that need follow-up. This review covers the additional 1.18.0 → 1.18.9 increment.
What's New in 1.18.0 → 1.18.9
- Performance (1.18.0 → 1.18.9): Further source-gen JIT overhead reductions via metadata factory helpers and
ParameterMetadataFactorywith lazyReflectionInforesolution — continuing the performance trajectory from 1.18.0. These are internal implementation changes with no API surface impact. - Feature: Distributed trace collection for the HTML test report (opt-in, purely additive).
- No breaking changes noted across any of the intermediate releases.
Assessment: Looks good ✓
The change is clean and correct:
- All three TUnit packages remain in sync at 1.18.9 — required since they share internal coupling.
- Change is correctly confined to
Directory.Packages.props(Central Package Management) — no individual.csprojfiles need modification. - No breaking changes across the full 1.17.25 → 1.18.9 range.
- The performance improvements (JIT reduction, metadata factory helpers) are a net benefit for test startup time with no consumer-facing risk.
Codacy and CodeFactor are both passing with no issues. Safe to merge once the CI pipeline jobs complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
a2214e9 to
5c78678
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: TUnit 1.17.25 → 1.18.21 Dependency Update
This PR (updated by Renovate bot) bumps all three TUnit packages in Directory.Packages.props:
TUnit1.17.25 → 1.18.21TUnit.Assertions1.17.25 → 1.18.21TUnit.Core1.17.25 → 1.18.21
Previous Reviews: Addressed ✓
Previous reviews covered through 1.18.9 with no concerns raised. This review covers the 1.18.9 → 1.18.21 increment.
What's New in 1.18.9 → 1.18.21
- Performance: Avoids string allocations by using
AppendJoin— a minor but welcome memory optimization. - Bug fix: Respect attribute namespace during migration — unlikely to affect this repo but correct behavior nonetheless.
- Bug fix: Parent data source initialization spans are now correctly placed under the session span in distributed tracing — relevant if the HTML report with distributed traces (added in 1.18.9) is being used.
- Dependency updates:
microsoft.testing.extensions.codecoveragebumped to 18.5.2,polyfillto 9.15.0 — routine internal deps, no consumer-facing impact.
Assessment: Looks good ✓
The change is clean and correct:
- All three TUnit packages remain in sync at 1.18.21 — required since they share internal coupling.
- Change is correctly confined to
Directory.Packages.props(Central Package Management). - No breaking changes across the full 1.17.25 → 1.18.21 range.
- The string allocation fix is a net positive with zero risk.
CodeFactor is passing with no issues. Safe to merge once the CI pipeline jobs complete.
2 participants
This PR contains the following updates:
1.17.25→1.18.211.17.25→1.18.211.17.25→1.18.21Release Notes
thomhurst/TUnit (TUnit)
v1.18.21: 1.18.21What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.18.9...v1.18.21
v1.18.9: 1.18.9What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.18.0...v1.18.9
v1.18.0: 1.18.0What's Changed
Other Changes
--results-directoryin documentation by @vbreuss in #5038Dependencies
Full Changelog: thomhurst/TUnit@v1.17.54...v1.18.0
v1.17.54: 1.17.54What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.17.36...v1.17.54
v1.17.36: 1.17.36What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.17.29...v1.17.36
v1.17.29: 1.17.29What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.17.25...v1.17.29
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.