Skip to content

[CLI] create-stylus fixes #8724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xFirekeeper merged 1 commit into from
Mar 26, 2026
+7 −2
Merged

[CLI] create-stylus fixes #8724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/funny-cars-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

[CLI] create-stylus fixes
4 changes: 2 additions & 2 deletions packages/thirdweb/src/cli/commands/stylus/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export async function createStylusProject() {

// Step 2: Install stylus etc.
spinner.start("Installing Stylus...");
const install = spawnSync("cargo", ["install", "--force", "cargo-stylus"], {
const install = spawnSync("cargo", ["install", "cargo-stylus"], {
stdio: "inherit",
});
if (install.status !== 0) {
Expand All @@ -33,7 +33,7 @@ export async function createStylusProject() {
}
spinner.succeed("Stylus installed.");

spawnSync("rustup", ["default", "1.87"], {
spawnSync("rustup", ["default", "stable"], {
stdio: "inherit",
});
Comment on lines +36 to 38
Copy link
Copy Markdown
Contributor

@graphite-app graphite-app bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rustup default stable command has no error handling. If this command fails (e.g., rustup not installed, network issues), the script will silently continue without setting the correct Rust toolchain, potentially causing subsequent commands to fail with unclear errors.

Should add status check similar to the cargo install command:

const rustupDefault = spawnSync("rustup", ["default", "stable"], {
  stdio: "inherit",
});
if (rustupDefault.status !== 0) {
  spinner.fail("Failed to set Rust toolchain to stable.");
  process.exit(1);
}
Suggested change
spawnSync("rustup", ["default", "stable"], {
stdio: "inherit",
});
const rustupDefault = spawnSync("rustup", ["default", "stable"], {
stdio: "inherit",
});
if (rustupDefault.status !== 0) {
spinner.fail("Failed to set Rust toolchain to stable.");
process.exit(1);
}

Spotted by Graphite

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

spawnSync("rustup", ["target", "add", "wasm32-unknown-unknown"], {
Expand Down
Loading