Skip to content

Clarify custom-chain bundler requirements#949

Draft
defiQUG wants to merge 1 commit into
thirdweb-dev:mainfrom
defiQUG:docs/custom-chain-bundler-clarity
Draft

Clarify custom-chain bundler requirements#949
defiQUG wants to merge 1 commit into
thirdweb-dev:mainfrom
defiQUG:docs/custom-chain-bundler-clarity

Conversation

@defiQUG

@defiQUG defiQUG commented Jul 12, 2026

Copy link
Copy Markdown

Summary

  • clarify in the README that chain overrides resolve custom EVM chains for standard Engine operations, but do not by themselves enable hosted bundler/paymaster support
  • expand the generic invalid-chain error message so operators using smart wallet / UserOp routes are not pointed only at chain overrides

Why

Engine supports custom chain overrides, but the UserOp routes still post to https://{chainId}.bundler.thirdweb.com. In practice that means a custom chain can be valid for normal Engine reads/writes/deployments while still failing for smart wallet flows if hosted bundler support is unavailable.

This change keeps the scope narrow and just makes that boundary explicit.

Validation

  • local diff review only
  • attempted to run the repo build/lint flow via Corepack/Yarn in this environment, but dependency install did not complete cleanly enough to provide working tsc / biome binaries before publish

PR-Codex overview

This PR enhances error messaging and documentation regarding custom chains in the project. It clarifies the requirements for using smart wallets and UserOp routes with custom chains.

Detailed summary

  • Updated the error message in the badChainError function to include information about bundler support requirements for smart wallet and UserOp routes.
  • Added a new section in README.md about custom chains, explaining chain overrides and their dependencies on bundler support.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8eaa1188-3625-4703-add2-f66d621f2e54

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant