Clarify custom-chain bundler requirements#949
Draft
defiQUG wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Engine supports custom chain overrides, but the UserOp routes still post to
https://{chainId}.bundler.thirdweb.com. In practice that means a custom chain can be valid for normal Engine reads/writes/deployments while still failing for smart wallet flows if hosted bundler support is unavailable.This change keeps the scope narrow and just makes that boundary explicit.
Validation
tsc/biomebinaries before publishPR-Codex overview
This PR enhances error messaging and documentation regarding custom chains in the project. It clarifies the requirements for using smart wallets and UserOp routes with custom chains.
Detailed summary
badChainErrorfunction to include information about bundler support requirements for smart wallet and UserOp routes.README.mdabout custom chains, explaining chain overrides and their dependencies on bundler support.