Audio: add CTC to PTL rt5682 path.#10696
Open
eddy1021 wants to merge 1 commit intothesofproject:mainfrom
Open
Conversation
johnylin76
reviewed
Apr 13, 2026
lgirdwood
reviewed
Apr 13, 2026
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Looks good, just the opens already mentioned.
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
1d53704 to
63efc72
Compare
lgirdwood
reviewed
Apr 17, 2026
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
There a lot of change here including in common files, can you add more context in the commit message especially around the changes in any common files.
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
63efc72 to
c74ac5a
Compare
Author
|
Added more details in the commit message now. Thanks! |
johnylin76
reviewed
Apr 20, 2026
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
c74ac5a to
12be0cd
Compare
lgirdwood
reviewed
Apr 21, 2026
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
12be0cd to
20d34d4
Compare
lgirdwood
reviewed
Apr 22, 2026
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Almost ready, just one question.
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
20d34d4 to
19be29b
Compare
lgirdwood
approved these changes
Apr 27, 2026
Member
|
@johnylin76 good for you ? |
johnylin76
approved these changes
Apr 30, 2026
Contributor
johnylin76
left a comment
johnylin76
left a comment
There was a problem hiding this comment.
just a few suggestions for redundant settings and LTGM
| "cavs-rt5682\;sof-ptl-tas2563-rt5682-ctc\;PLATFORM=ptl,NUM_DMICS=2,DMIC0_PCM_ID=99,PREPROCESS_PLUGINS=nhlt,\ | ||
| NHLT_BIN=nhlt-sof-ptl-tas2563-rt5682-ctc.bin,SPK_ID=6,DEEPBUFFER_FW_DMA_MS=10,INCLUDE_ECHO_REF=true,\ | ||
| BT_NAME=SSP2-BT,BT_ID=7,BT_PCM_NAME=Bluetooth,DEEP_BUF_SPK=true,PLAYBACK_PIPELINE_SRC=ctc,USE_CTC_SPK=true,\ | ||
| HEADSET_CODEC=true,HEADSET_CODEC_NAME=SSP0-Codec" |
Contributor
There was a problem hiding this comment.
HEADSET_CODEC=true,HEADSET_CODEC_NAME=SSP0-Codec probably don't need
| "cavs-rt5682\;sof-ptl-tas2563-rt5682-dax-ctc\;PLATFORM=ptl,NUM_DMICS=2,DMIC0_PCM_ID=99,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-ptl-tas2563-rt5682-dax-ctc.bin,SPK_ID=6,DEEPBUFFER_FW_DMA_MS=10,\ | ||
| INCLUDE_ECHO_REF=true,BT_NAME=SSP2-BT,BT_ID=7,BT_PCM_NAME=Bluetooth,DEEP_BUF_SPK=true,\ | ||
| PLAYBACK_PIPELINE_SRC=dax,DOLBY_DAX_CORE_ID=0,USE_CTC_SPK=true,HEADSET_CODEC=true,HEADSET_CODEC_NAME=SSP0-Codec" |
|
|
||
| Object.Base.route [ | ||
| { | ||
| source "dai-copier.SSP.$HEADSET_CODEC_NAME.capture" |
Contributor
There was a problem hiding this comment.
why do we have the routing for capture here? They should be defined in cavs-rt5682.conf already
Author
There was a problem hiding this comment.
Yes, it's not needed. Removed now. Thank you!
Include CTC component in PTL with rt5682. Introduce `USE_CTC_SPK` in `cavs-mixin-mixout-dax-ssp.conf` to conditionally include CTC component in the pipeline. Signed-off-by: Eddy Hsu <eddyhsu@google.com>
eddy1021
force-pushed
the
ctc_ptl_rt5682_2
branch
from
19be29b to
772720d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include CTC component in PTL with rt5682.