src: cosmetic: simplify an invalid configuration check#10626
Open
lyakh wants to merge 1 commit intothesofproject:mainfrom
Open
src: cosmetic: simplify an invalid configuration check#10626lyakh wants to merge 1 commit intothesofproject:mainfrom
lyakh wants to merge 1 commit intothesofproject:mainfrom
Conversation
The condition delay_lines_size == 0 in src_params_general() can trigger if cd->param.total == 0 or if cd->param.total == -1. However, the latter is supposedly invalid and should be checked in a more generic non-negativity test, so here it suffices to just check cd->param.total != 0 before delay_lines_size is calculated. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Simplifies the invalid configuration check in src_params_general() by directly validating cd->param.total before computing delay_lines_size.
Changes:
- Reorders validation to check
cd->param.total == 0before calculatingdelay_lines_size. - Updates the error message emitted on invalid configuration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+526
to
532
| if (cd->param.total == 0) { | ||
| comp_err(dev, "configuration failed: delay_lines_size = 0"); | ||
|
|
||
| return -EINVAL; | ||
| } | ||
| delay_lines_size = ALIGN_UP(sizeof(int32_t) * cd->param.total, 8); | ||
|
|
| if (delay_lines_size == 0) { | ||
| comp_err(dev, "delay_lines_size = 0"); | ||
| if (cd->param.total == 0) { | ||
| comp_err(dev, "configuration failed: delay_lines_size = 0"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition delay_lines_size == 0 in src_params_general() can trigger if cd->param.total == 0 or if cd->param.total == -1. However, the latter is supposedly invalid and should be checked in a more generic non-negativity test, so here it suffices to just check cd->param.total != 0 before delay_lines_size is calculated.