[WIP] FIX: Possible exception on corrupted cache loading#129
Draft
Fabio3rs wants to merge 6 commits intothelink2012:masterfrom
Draft
[WIP] FIX: Possible exception on corrupted cache loading#129Fabio3rs wants to merge 6 commits intothelink2012:masterfrom
Fabio3rs wants to merge 6 commits intothelink2012:masterfrom
Conversation
…d use it to clamp priority values, allowing for more flexible configuration
…instead of hardcoded 100
…uring cache operations feat(cache.hpp, main.cpp): log error messages with exception details when cache operations fail
ci(build.yml): add detailed comments explaining each step in the build process ci(build.yml): correct comment about MSBuild property precedence and toolset version ci(build.yml): update artifact collection comments to reflect current directory structure ci(build.yml): add comments explaining the purpose of the release job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases, the serialized ("cerealized"?) cache files from std.data could be corrupted, the next loading causes an untreated exception
This should fix it.
Possible TODOs: implement hashing/magics before calling cereal lib to unserialize
PS: there are my last PR commits here, we can cherry pick the try catch fix if the other PR were not merged.