Fix for ImGui 1.92.8: AddRect/PathStroke arg swap#339
Open
pthom wants to merge 1 commit into
Open
Conversation
Gate the 4 affected call sites (1 PathStroke + 3 AddRect) on IMGUI_VERSION_NUM < 19276 — last two args (flags, thickness) were swapped to (thickness, flags) in ocornut/imgui v1.92.8.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/ocornut/imgui/releases/tag/v1.92.8
There is a breaking change: "DrawList: swapped the last two arguments of AddRect(), AddPolyline(), PathStroke()"
Gate the 4 affected call sites (1 PathStroke + 3 AddRect) on IMGUI_VERSION_NUM < 19276
Note:
The change below in imgui_node_editor.cpp deserves some attention:
Because the old call
was passing "true" as a flag. This was changed to ImDrawFlags_Closed (which is always equal to 1).