docs: use queryByText in guide-disappearance.mdx#1532
Closed
davidjb wants to merge 1 commit intotesting-library:mainfrom
Closed
docs: use queryByText in guide-disappearance.mdx#1532davidjb wants to merge 1 commit intotesting-library:mainfrom
davidjb wants to merge 1 commit intotesting-library:mainfrom
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
Self-closing on account of the explanation at https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/prefer-presence-queries.md - the docs would benefit from distinguishing explicit choices on using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the first example on this page to use the
queryByfinder instead ofgetByto avoid throwing in the query itself.This gotcha gets explained a few times later in the doc (https://testing-library.com/docs/guide-disappearance#waiting-for-disappearance) but this is the first example you come to, and the use of
getByTextmeans theexpect(...).toBeInTheDocument()will never be called.