chore: RBS fixups#452
Open
chris-olszewski wants to merge 2 commits into
Open
Conversation
chris-olszewski
commented
Jun 3, 2026
|
|
||
| def fetch_history: ( | ||
| ?event_filter_type: Integer, | ||
| ?skip_archival: bool, |
Member
Author
There was a problem hiding this comment.
This was just flat out missing
| def code: -> Temporalio::Error::RPCError::Code::enum | ||
| def message: -> String | ||
| def details: -> String | ||
| def details: -> String? |
Member
Author
There was a problem hiding this comment.
We explicitly pass None across the boundary from the Rust side:
sdk-ruby/temporalio/ext/src/client.rs
Line 345 in c0f4ab4
chris-olszewski
force-pushed
the
olszewski/feat_publish_types-rbs
branch
from
f12459d to
66752b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
untypedto known typesWhy?
#410 will be very large regardless. I wanted to pull out any of the changes to existing code to a new PR to keep that one as focused on publishing RBI as possible.
Checklist
Closes N/A
How was this tested:
bundle exec rake steepAny docs updates needed?
N/A