Skip to content

chore: update submodule to sdk-rust #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-olszewski wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update submodule to sdk-rust #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f8c6cc
Rename sdk-core submodule repo to sdk-rust
chris-olszewski Apr 24, 2026
5baef23
update comments
chris-olszewski Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[submodule "sdk-core"]
path = temporalio/bridge/sdk-core
url = https://github.com/temporalio/sdk-core.git
url = https://github.com/temporalio/sdk-rust.git
branch = main
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1937,7 +1937,7 @@ users are encouraged to not use gevent in asyncio applications (including Tempor
# Development

The Python SDK is built to work with Python 3.9 and newer. It is built using
[SDK Core](https://github.com/temporalio/sdk-core/) which is written in Rust.
[SDK Core](https://github.com/temporalio/sdk-rust/) which is written in Rust.

### Building

Expand Down
6 changes: 3 additions & 3 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,7 @@ async def run(self, params: CancelActivityWorkflowParams) -> None:
self._activity_result = await handle
except ActivityError as err:
self._activity_result = f"Error: {err.cause.__class__.__name__}"
# TODO(cretz): Remove when https://github.com/temporalio/sdk-core/issues/323 is fixed
# TODO(cretz): Remove when https://github.com/temporalio/sdk-rust/issues/323 is fixed
except CancelledError as err:
self._activity_result = f"Error: {err.__class__.__name__}"
# Wait forever
Expand Down Expand Up @@ -2430,7 +2430,7 @@ async def test_workflow_dataclass_typed(client: Client, env: WorkflowEnvironment
# TODO(cretz): Fix
if env.supports_time_skipping:
pytest.skip(
"Java test server: https://github.com/temporalio/sdk-core/issues/390"
"Java test server: https://github.com/temporalio/sdk-rust/issues/390"
)
async with new_worker(
client, DataClassTypedWorkflow, activities=[data_class_typed_activity]
Expand Down Expand Up @@ -7246,7 +7246,7 @@ async def test_workflow_deadlock_interruptible(client: Client):
# TODO(cretz): Improve this test and other deadlock/eviction tests by
# checking slot counts with Core. There are a couple of bugs where used slot
# counts are off by one and slots are released before eviction (see
# https://github.com/temporalio/sdk-core/issues/894).
# https://github.com/temporalio/sdk-rust/issues/894).

# This worker used to not be able to shutdown because we hung evictions on
# deadlock
Expand Down
Loading