Skip to content

Remove Netty versions metadata from shaded jar#2929

Open
nanne-rl wants to merge 1 commit into
temporalio:masterfrom
nanne-rl:fix-shaded-netty-versions-properties
Open

Remove Netty versions metadata from shaded jar#2929
nanne-rl wants to merge 1 commit into
temporalio:masterfrom
nanne-rl:fix-shaded-netty-versions-properties

Conversation

@nanne-rl

Copy link
Copy Markdown

What changed?

  • Exclude META-INF/io.netty.versions.properties from the temporal-shaded jar.

Why?

grpc-netty-shaded contributes Netty's versions metadata to temporal-shaded. Consumers that scan classpaths for Netty version mismatches can treat temporal-shaded as another Netty distribution and emit inconsistent version warnings, even though the classes are relocated.

Breaking changes?

No.

Server PR

None.

Testing

  • JAVA_HOME=/nix/store/bp2gjhd8vfyv2hg0i90sba2wp47vvflg-zulu-ca-jdk-21.0.11 PATH=/nix/store/bp2gjhd8vfyv2hg0i90sba2wp47vvflg-zulu-ca-jdk-21.0.11/bin:/Users/nanne/.nix-profile/bin:/usr/bin:/bin:/usr/sbin:/sbin ./gradlew --gradle-user-home .gradle --offline :temporal-shaded:shadowJar
  • Verified temporal-shaded/build/libs/temporal-shaded-unknown.jar does not contain META-INF/io.netty.versions.properties.
  • Verified the shaded jar manifest still contains Multi-Release: true.

@nanne-rl nanne-rl requested a review from a team as a code owner June 25, 2026 13:16
@CLAassistant

CLAassistant commented Jun 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants