Conversation
Quinn-With-Two-Ns
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used a workflow id that had a space in it, and realized that the links to it in the UI workflow step were broken. They should have linked to "workflow%20id" for example, but instead linked to "workflow%2Bid". This will only show up if you have a space in the workflow ID, so that is why it was missed.
The root issue turns out to be that the URLEncoder is meant for forms, where this is evidently the standard.
The solution used here is to encode the string, then replace any "+" values with "%20". If the string has a plus, it will be converted to "%2B" by the call, so will not be affected by the replace (that is being double checked by the unit test.)