test: fix concurrent start test assertions#1094
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #581 by removing
testing.Tassertions from the worker goroutines inTestServer_StartDev_ConcurrentStarts. Each concurrent start now returns anerror, and the main test goroutine collects those errors and reports them withrequire.NoError.The test still starts 40 dev server instances with a fixed worker pool of 6 concurrent executions. The replacement command helper runs
server start-devwith a cancellable context and captured stdout/stderr, so failures from early command exit or cleanup are preserved in the final assertion message without callingFailNow-style methods outside the test goroutine.Verification
gofmt -w internal/temporalcli/commands.server_test.gogit diff --checkgo test ./internal/temporalcli -run '^TestServer_StartDev_ConcurrentStarts$' -count=1