Skip to content

test: fix concurrent start test assertions#1094

Open
nanookclaw wants to merge 1 commit into
temporalio:mainfrom
nanookclaw:fix/concurrent-starts-test-harness
Open

test: fix concurrent start test assertions#1094
nanookclaw wants to merge 1 commit into
temporalio:mainfrom
nanookclaw:fix/concurrent-starts-test-harness

Conversation

@nanookclaw

Copy link
Copy Markdown

Summary

Fixes #581 by removing testing.T assertions from the worker goroutines in TestServer_StartDev_ConcurrentStarts. Each concurrent start now returns an error, and the main test goroutine collects those errors and reports them with require.NoError.

The test still starts 40 dev server instances with a fixed worker pool of 6 concurrent executions. The replacement command helper runs server start-dev with a cancellable context and captured stdout/stderr, so failures from early command exit or cleanup are preserved in the final assertion message without calling FailNow-style methods outside the test goroutine.

Verification

  • gofmt -w internal/temporalcli/commands.server_test.go
  • git diff --check
  • go test ./internal/temporalcli -run '^TestServer_StartDev_ConcurrentStarts$' -count=1

@nanookclaw nanookclaw requested a review from a team as a code owner June 21, 2026 04:27
@CLAassistant

CLAassistant commented Jun 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Dev Server concurrent execution test is incorrect and flaky

2 participants