Skip to content

Add client-authority support to config profile settings#1084

Open
NasitSony wants to merge 5 commits into
temporalio:mainfrom
NasitSony:fix/add-client-authority-to-config
Open

Add client-authority support to config profile settings#1084
NasitSony wants to merge 5 commits into
temporalio:mainfrom
NasitSony:fix/add-client-authority-to-config

Conversation

@NasitSony

@NasitSony NasitSony commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related issues

Closes #1013

What changed?

  • Added authority to envConfigPropsToFieldNames map so
    client-authority can be get/set via config commands
  • Wired cfg.ClientAuthority to profile.Authority in client.go
  • Updated DefaultConfigFilePath() call sites for envconfig v1.0.2
    signature change (returns string instead of (string, error))
  • Bumped go.temporal.io/sdk/contrib/envconfig to v1.0.2
  • Added authority field to config tests

Checklist

Stability

  • ✅ No breaking changes
  • ✅ Works against OSS server
  • ✅ Flag named after API concept (client-authority)
  • ✅ No duplicate flags
  • ✅ No short aliases
  • ✅ Added test coverage in commands.config_test.go

Design

  • ✅ Works against OSS server
  • ✅ Flag named after API concept (client-authority)
  • ✅ No duplicate flags
  • ✅ No short aliases

Tests

  • Added functional test (SharedServerSuite) — config set/get test needed

Manual tests

Setup

temporal server start-dev --headless

Happy path

$ temporal config set --prop authority --value my-authority
$ temporal config get --prop authority
Property   Value
authority   my-authority

Error case

$ temporal config set --prop authority
Error: required flag --value not set

@NasitSony NasitSony requested a review from a team as a code owner June 5, 2026 21:46
spkane31
spkane31 requested changes Jun 10, 2026
View reviewed changes
Comment thread internal/temporalcli/commands.schedule.go Outdated
package temporalcli

import (
"encoding/json"

@spkane31 spkane31 Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the changes to search attributes in schedules required for this change?

@NasitSony NasitSony Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spkane31 Good catch! That was an unrelated change from another branch
that got included by mistake. I've rebased the PR onto main —
those changes are now removed.

Comment thread internal/temporalcli/commands.config_test.go
"address": "my-address",
"namespace": "my-namespace",
"api_key": "my-api-key",
"authority": "my-authority",

@spkane31 spkane31 Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the config set path ?

@NasitSony NasitSony Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spkane31 Sure, I'll add a test for the config set path in the next commit.

@NasitSony NasitSony Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spkane31 Added test for config set path in the latest commit.

NasitSony added 2 commits June 10, 2026 18:49
@NasitSony
Add client-authority support to config profile settings
0d26226 
Wire ClientAuthority flag into the envconfig ClientConfigProfile
so it can be set via 'temporal config set --prop client-authority'.

Also updates DefaultConfigFilePath() call sites to handle the
updated signature in envconfig v1.0.2 which now returns a single
string instead of (string, error).

Fixes temporalio#1013
@NasitSony
Add client-authority support to config profile settings
52e0f62 
Wire ClientAuthority flag into envconfig ClientConfigProfile so
it can be set and retrieved via 'temporal config set/get':

  temporal config set --prop client-authority --value my-authority
  temporal config get --prop client-authority

Changes:
- Add 'authority' to envConfigPropsToFieldNames map in commands.config.go
- Wire cfg.ClientAuthority to profile.Authority in client.go
- Update DefaultConfigFilePath() call sites for envconfig v1.0.2
  signature change (string instead of string, error)
- Bump go.temporal.io/sdk/contrib/envconfig to v1.0.2
- Add authority field to config tests

Fixes temporalio#1013
@NasitSony NasitSony force-pushed the fix/add-client-authority-to-config branch from 2289be9 to 52e0f62 Compare June 11, 2026 01:49
@spkane31

spkane31 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor 
$ temporal config set --prop client-authority --value my-authority
$ temporal config get --prop client-authority
my-authority

I think these are wrong in your PR description, it should be --prop authority

@NasitSony

NasitSony commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@spkane31 Thank you for pointing that out. I have just edited the PR to correct it.

@NasitSony NasitSony requested a review from spkane31 June 12, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spkane31 spkane31 Awaiting requested review from spkane31

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add client-authority to config settings

2 participants

@NasitSony @spkane31