Fix username in default reason string#1002
Open
dandavison wants to merge 3 commits intomainfrom
Open
Conversation
The success branch of `user.Current()` was guarded by `err != nil` so the resolved username was never used and `defaultReason()` always rendered as `Requested from CLI by <unknown-user>`, making the recorded audit trail useless for distinguishing operators in the failure body of terminated activities and similar default-reason call sites. Run the test: go test ./internal/temporalcli/ -run 'TestSharedServerSuite/TestActivity_Terminate_DefaultReason_NoUnknownUser$' -v
chaptersix
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Use username in default reason when username is available.
Why?
It's what was intended; the code just had a typo.
How was this tested: