Add --graphics option to replace --no-graphic and --vnc#24
Open
thrix wants to merge 1 commit into
Open
Conversation
Replace the non-functional `--no-graphic` and `--vnc` CLI flags with a
single `--graphics {spice,vnc,none}` option that actually wires through
to the libvirt domain XML.
This is useful when one needs graphical access to the VM via a SPICE or
VNC client (e.g. `virt-viewer` or `remote-viewer`), for example to debug
boot issues or interact with a graphical desktop.
The old flags were accepted by argparse but never consumed — they had
zero effect on VM creation. The new option generates proper `<graphics>`
and `<video>` elements in the domain XML. For `qemu:///system`
connections, the graphics display binds to `127.0.0.1` for security.
Also removes the unused `self.vnc` and `self.graphics` attributes from
the `Instance` class.
Assisted-by: Claude Code
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the non-functional
--no-graphicand--vncCLI flags with a single--graphics {spice,vnc,none}option that actually wires through to the libvirt domain XML.This is useful when one needs graphical access to the VM via a SPICE or VNC client (e.g.
virt-viewerorremote-viewer), for example to debug boot issues or interact with a graphical desktop.The old flags were accepted by argparse but never consumed — they had zero effect on VM creation. The new option generates proper
<graphics>and<video>elements in the domain XML. Forqemu:///systemconnections, the graphics display binds to127.0.0.1for security.Also removes the unused
self.vncandself.graphicsattributes from theInstanceclass.I needed this while working on Fedora CSB :)
Assisted-by: Claude Code