-
Notifications
You must be signed in to change notification settings - Fork 445
Add support for receiving "Customized Monthly" schedule intervals #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for parsing "Customized Monthly" schedules in the Tableau Server Client. The change handles a new monthly interval type that can be returned by the Tableau API.
- Added "Customized Monthly" as a valid monthly interval value
- Added test coverage for parsing customized monthly schedules
- Created test fixture for customized monthly schedule XML response
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tableauserverclient/models/interval_item.py | Added "Customized Monthly" to the list of valid monthly interval values |
| test/test_schedule.py | Added test case and test fixture constant for customized monthly schedule |
| test/assets/schedule_get_customized_monthly_id.xml | Added XML fixture representing a customized monthly schedule response |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jorwoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to recreate a server responding with "Customized Monthly", but I see no issues with adding it.
jacalata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this string may have been removed since this was reported, but this will make the library work for people running against 2022 or other builds that return it.
|
Ahh the string being removed might help explain why I had a hard time testing this :) |
* feat: New APIs: Update multiple connections in a single workbook/datasource (#1638) * feat: enable toggling attribute capture for a site (#1619) * feat: support OIDC endpoints (#1630) * feat: add WebAuthoringForFlows capability to Permission class (#1642) * feat: support collections in favorites (#1647) * feat: Add UAT (unified access token) support to JWT login (#1671) * feat: Update permissions_item.py --added ExtractRefresh attribute (#1617) (#1669) * feat: make refresh consistent between endpoints (#1665) * feat: make ResourceReference hashable (#1668) Closes #1666 * feat: delete view (#1712) * feat: batch create schedule (#1714) * feat: users csv import (#1409) * feat: implement users bulk_remove * feat: enable idp_configuration_id in bulk_add * feat: support extensions api (#1672) * feat: Add support for receiving "Customized Monthly" schedule intervals (#1670) * feat: implement #816: project.get_by_id (#1736) * fix: put special fields first (#1622) Closes #1620 * fix: virtual connections username (#1628) Closes #1626 * fix: add contentType to tags batch actions (#1643) * fix: datasource owner/project missing parsing (#1700) * fix: datasource description update and publish (#1682) * fix: windows decoding error * fix: assert on warning instead of ignore * fix: add workbook and view setter for custom view (#1730) * fix: handle parameters for view filters (#1633) * fix: handle parameters for view filters Closes #1632
Add handling to recognize "Customized Monthly" as a possible interval type that can be returned for schedules.
Also add a test with a simulated xml response to confirm.
Fixes #1365