Improve test-matrix coverage#186
Merged
jserv merged 1 commit intoJul 9, 2026
Merged
Conversation
tests/manifest.txt duplicated most of test-matrix.sh's coverage: every
portable syscall test ran through both make check (elfuse only) and
the matrix (elfuse + qemu reference kernel), so additions and
failures had to be tracked in two places.
Trim manifest.txt to what make check actually needs on its own: tests
that assert elfuse-internal behavior with no real-kernel equivalent
(the EL1 shim fast-path suite, test-mremap-infra, test-oom-proc),
plus whatever mk/tests.mk's SANITIZER_SECTIONS pulls in for
check-{asan,ubsan,tsan} -- those need a sanitizer-instrumented elfuse
binary that only driver.sh can point at, which qemu-aarch64's
uninstrumented real kernel can't substitute for.
Everything else now lives exclusively in test-matrix.sh's
run_unit_tests, which folds in what used to be a separate
run_extended_unit_tests. There is no more core/extended split, just
one list that runs against both elfuse and the qemu reference kernel.
make check: 69 tests (down from 118), still green. test-matrix:
234/0/4 (elfuse-aarch64), 214/0/24 (qemu-aarch64), unchanged from
before the split.
Contributor
|
Consolidate the test suite by removing duplicate tests and ensuring comprehensive coverage before transitioning to LTP. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Max042004
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/manifest.txtfrom 118 to 69 entries: keep only tests with no real-kernel equivalent (EL1 shim fast-path suite,test-mremap-infra,test-oom-proc) plus whateverSANITIZER_SECTIONSneeds for thecheck-{asan,ubsan,tsan}lanes.test-matrix.shnow covers the full portable test surface against bothelfuse-aarch64andqemu-aarch64.make checknow owns only what it uniquely needs — elfuse-internal plumbing and sanitizer coverage — whiletest-matrix.shis the sole, comprehensive cross-kernel gate.docs/testing.mdto describe the new split and adjust the recommended dev workflow (make checkalone no longer substitutes formake test-matrix-elfuse-aarch64).Test
make check: 69/0, all stages green (busybox, sysroot, FUSE, Rosetta CLI gating, hot-syscall guardrail)driver.sh -l -s '<SANITIZER_SECTIONS>'still matches the same 48 sanitizer-relevant testsbash tests/test-matrix.sh elfuse-aarch64: 234 passed, 0 failed, 4 skippedbash tests/test-matrix.sh qemu-aarch64: 214 passed, 0 failed, 24 skippedSummary by cubic
Narrowed
make checkto elfuse-internal and sanitizer-only tests, and moved all portable tests into the matrix runner to remove duplicate gates while keeping coverage the same. The matrix is now the single, comprehensive cross-kernel gate.Refactors
tests/manifest.txtfrom 118 to 69 tests: keep EL1 shim fast-path,test-mremap-infra,test-oom-proc, plus sanitizer-selected tests.run_unit_teststhat exercises the full portable suite againstelfuse-aarch64andqemu-aarch64.QEMU_SKIP, updated expected baselines, and refresheddocs/testing.mdto reflect the new split.Migration
make elfuse && make check && make test-matrix-elfuse-aarch64.make test-matrix-qemu-aarch64ormake test-matrix.Written for commit 4cab69b. Summary will update on new commits.