refactor(api): standardize public route casing on lowercase#34
Merged
refactor(api): standardize public route casing on lowercase#34
Conversation
Companion to syscoin/sysnode-backend#23. The historical canonical URL for the public sysnode-backend endpoints is lowercase: syshub still calls `https://syscoin.dev/mnstats` lowercase, and `/govlist` was already lowercase. The camelCase only appeared because the backend route files registered `router.get("/mnStats", …)`; Express's default case-insensitive routing hid the drift across both ends. Pin the SPA on the lowercase canonical so future readers and external integrators see one consistent shape: - src/lib/api.js: client.get('/mnstats'), client.get('/mncount'). - README data-source layout block updated. - Comments in NewProposal.{js,test.js} and governanceWindow.{js,test.js} refreshed to use the lowercase path names. (Behaviourally these are documentation refs; the request URL change is in api.js.) Backwards compat: the backend's case-insensitive default routing AND the case-insensitive `~*` regex match in the bundled nginx example (syscoin/sysnode-backend#23) mean any in-flight build still using camelCase keeps working during a rolling deploy. New code paths land on lowercase from the start. 880 jest tests pass. Made-with: Cursor
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to syscoin/sysnode-backend#23. The historical canonical URL for the public sysnode-backend endpoints is lowercase —
syshubstill callshttps://syscoin.dev/mnstatslowercase, and/govlistwas already lowercase. The camelCase only appeared because the backend route files registeredrouter.get("/mnStats", …); Express's default case-insensitive routing hid the drift across both ends.This pins the SPA on the lowercase canonical so future readers and external integrators see one consistent shape.
src/lib/api.js:client.get('/mnstats'),client.get('/mncount').README.mddata-source layout block updated.NewProposal.{js,test.js}andgovernanceWindow.{js,test.js}refreshed to use the lowercase path names.Backwards compatibility
The backend's case-insensitive default routing AND the case-insensitive
~*regex match in the bundled nginx example (sysnode-backend#23) mean any in-flight SPA build still using camelCase keeps working during a rolling deploy. New code paths land on lowercase from the start.Test plan
CI=true npm test -- --watchAll=false(880/880 pass)https://sysnode.dev11.top/, confirm dashboard stats render and the network status block populates (proves/mnstatslookup succeeded same-origin).Made with Cursor