Skip to content

Use practical vault password complexity#29

Merged
sidhujag merged 1 commit intomasterfrom
hardening/password-composition-policy
Apr 25, 2026
Merged

Use practical vault password complexity#29
sidhujag merged 1 commit intomasterfrom
hardening/password-composition-policy

Conversation

@sidhujag
Copy link
Copy Markdown
Member

Summary

  • Replace the 16-character hard floor with an 8-character minimum plus 3 of lowercase/uppercase/number/symbol.
  • Keep the centralized vault password policy used by registration, first-write import, VaultContext first writes, and password changes.
  • Update validation copy and tests to match the practical composition rule.

Test plan

  • CI=true npm test -- --watch=false --runInBand src/pages/Register.test.js src/components/ChangePasswordCard.test.js src/components/VaultImportModal.test.js src/context/VaultContext.test.js

Made with Cursor

Replace the 16-character hard floor with an 8-character minimum plus three character classes for new vault passwords.

Made-with: Cursor
@sidhujag
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag sidhujag merged commit 8c6fe20 into master Apr 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant