Skip to content

Resolve android pubky parity issues from #902#905

Open
ben-kaufman wants to merge 15 commits intomasterfrom
codex-pubky-902-android
Open

Resolve android pubky parity issues from #902#905
ben-kaufman wants to merge 15 commits intomasterfrom
codex-pubky-902-android

Conversation

@ben-kaufman
Copy link
Copy Markdown
Contributor

@ben-kaufman ben-kaufman commented Apr 23, 2026

resolves #902

Description

  • restore pubky sessions from wallet backups and reinitialize pubky after wallet restore
  • align Android profile and contacts flows with the iOS parity work where applicable
  • improve pubky routing from clipboard and scanner input
  • polish profile/contact edit flows, delete flows, and related copy
  • add unit coverage for pubky restore, delete recovery, and contact import routing

Preview

  • N/A

QA Notes

  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt
  • installed and launched to.bitkit.dev on connected device 2409BRN2CA

@ben-kaufman ben-kaufman marked this pull request as ready for review April 23, 2026 12:58
@ben-kaufman ben-kaufman changed the title [codex] resolve android pubky parity issues from #902 Resolve android pubky parity issues from #902 Apr 23, 2026
@ben-kaufman ben-kaufman requested a review from piotr-iohk April 23, 2026 12:58
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/repositories/BackupRepo.kt Outdated
piotr-iohk
piotr-iohk reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
@piotr-iohk piotr-iohk mentioned this pull request Apr 23, 2026
Open
@piotr-iohk

This comment was marked as resolved.

Sign in to view
ben-kaufman and others added 4 commits April 23, 2026 10:06
@ben-kaufman @piotr-iohk
Update app/src/main/res/values/strings.xml
48b29f6 
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman @piotr-iohk
Update app/src/main/res/values/strings.xml
efdbf06 
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman @piotr-iohk
Update app/src/main/res/values/strings.xml
2e2706b 
Co-authored-by: piotr-iohk <42900201+piotr-iohk@users.noreply.github.com>
@ben-kaufman
fix: truncate pubky contact names
a787832
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/ui/components/Tag.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/ui/components/ProfileEditForm.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/test/java/to/bitkit/ui/WalletViewModelTest.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/test/java/to/bitkit/ui/screens/contacts/ContactImportFlowTest.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/repositories/BackupRepo.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/ui/screens/profile/EditProfileViewModel.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/ui/screens/contacts/ContactsScreen.kt Outdated
claude[bot]
claude Bot reviewed Apr 23, 2026
View reviewed changes
Comment thread app/src/main/java/to/bitkit/repositories/PubkyRepo.kt Outdated
@claude

This comment has been minimized.

Sign in to view
This was referenced Apr 24, 2026
Open
Open
@jvsena42
Copy link
Copy Markdown
Member

jvsena42 commented Apr 24, 2026 •
edited
Loading

  1. Could add a line limit for the name on Add Contact screen too
  2. Should it display the onboarding screen for contacts even if the user already has them? When I click in "Add contact, it display the contact list"

✅All the other points I pointed in the previous PR are good

Screen_recording_20260424_072541.webm

@jvsena42
Copy link
Copy Markdown
Member

jvsena42 commented Apr 24, 2026 •
edited
Loading

PS: please, mark the comments as solved after fix them. Helps identify what is still pending 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piotr-iohk piotr-iohk piotr-iohk left review comments

@claude claude[bot] claude[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ben-kaufman ben-kaufman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pubky profile & contacts — outstanding work (Android + iOS)

3 participants

@ben-kaufman @piotr-iohk @jvsena42