Skip to content

feat: Removed Update Banner on json outputs #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex793x merged 1 commit into from
Sep 12, 2025
Merged

feat: Removed Update Banner on json outputs #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 34 additions & 10 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,16 @@ async fn run() -> syncable_cli::Result<()> {
println!("✅ Update cache cleared. Checking for updates now...");
}

check_for_update().await;
// Suppress update banner when JSON output is requested
let suppress_update_banner = cli.json || matches!(
&cli.command,
Commands::Analyze { json: true, .. }
| Commands::Dependencies { format: OutputFormat::Json, .. }
| Commands::Vulnerabilities { format: OutputFormat::Json, .. }
| Commands::Security { format: OutputFormat::Json, .. }
| Commands::Tools { command: ToolsCommand::Status { format: OutputFormat::Json, .. } }
);
check_for_update(suppress_update_banner).await;

// Initialize logging
cli.init_logging();
Expand Down Expand Up @@ -266,7 +275,10 @@ async fn run() -> syncable_cli::Result<()> {
properties.insert("dev_only".to_string(), json!(true));
}

let format_str = match format {
// Honor global --json flag for output selection
let effective_format = if cli.json { OutputFormat::Json } else { format };

let format_str = match effective_format {
OutputFormat::Table => "table",
OutputFormat::Json => "json",
};
Expand All @@ -277,7 +289,7 @@ async fn run() -> syncable_cli::Result<()> {
telemetry_client.track_dependencies(properties);
}

handle_dependencies(path, licenses, vulnerabilities, prod_only, dev_only, format)
handle_dependencies(path, licenses, vulnerabilities, prod_only, dev_only, effective_format)
.await
.map(|_| ())
},
Expand All @@ -300,7 +312,10 @@ async fn run() -> syncable_cli::Result<()> {
properties.insert("severity_threshold".to_string(), json!(severity_str));
}

let format_str = match format {
// Honor global --json flag for output selection
let effective_format = if cli.json { OutputFormat::Json } else { format };

let format_str = match effective_format {
OutputFormat::Table => "table",
OutputFormat::Json => "json",
};
Expand All @@ -315,7 +330,7 @@ async fn run() -> syncable_cli::Result<()> {
telemetry_client.track_vulnerabilities(properties);
}

handle_vulnerabilities(path, severity, format, output).await
handle_vulnerabilities(path, severity, effective_format, output).await
},
Commands::Security {
path,
Expand Down Expand Up @@ -366,7 +381,10 @@ async fn run() -> syncable_cli::Result<()> {
properties.insert("compliance_frameworks".to_string(), json!(frameworks));
}

let format_str = match format {
// Honor global --json flag for output selection
let effective_format = if cli.json { OutputFormat::Json } else { format };

let format_str = match effective_format {
OutputFormat::Table => "table",
OutputFormat::Json => "json",
};
Expand Down Expand Up @@ -394,7 +412,7 @@ async fn run() -> syncable_cli::Result<()> {
no_infrastructure,
no_compliance,
frameworks,
format,
effective_format,
output,
fail_on_findings,
)
Expand Down Expand Up @@ -506,7 +524,11 @@ fn clear_update_cache() {
}
}

async fn check_for_update() {
async fn check_for_update(suppress_output: bool) {
// In JSON mode (or when suppressed), avoid any banner or network I/O
if suppress_output {
return;
}
let cache_dir_path = cache_dir()
.unwrap_or_else(|| PathBuf::from("."))
.join("syncable-cli");
Expand Down Expand Up @@ -617,7 +639,9 @@ async fn check_for_update() {
&& latest != current
&& is_version_newer(current, latest)
{
show_update_notification(current, latest);
if !suppress_output {
show_update_notification(current, latest);
}
}
}
Err(e) => {
Expand Down Expand Up @@ -1136,4 +1160,4 @@ pub fn handle_security(

async fn handle_tools(command: ToolsCommand) -> syncable_cli::Result<()> {
syncable_cli::handlers::tools::handle_tools(command).await
}
}