jextract/jni: Fix code generation for optional String in tuples#724
Open
sidepelican wants to merge 1 commit intoswiftlang:mainfrom
Open
jextract/jni: Fix code generation for optional String in tuples#724sidepelican wants to merge 1 commit intoswiftlang:mainfrom
String in tuples#724sidepelican wants to merge 1 commit intoswiftlang:mainfrom
Conversation
ktoso
approved these changes
Apr 27, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Love removing edge cases :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was a special handling logic for
Stringwithin tuples, but this logic was not applied toString?, leading to incorrect output.By leveraging the
nativeJavaTypeintroduced in #722, I was able to remove this special-case logic entirely.