fix(web): strengthen URL validation and redirect handling in OG scraper#1059
Open
RinZ27 wants to merge 1 commit into
Open
fix(web): strengthen URL validation and redirect handling in OG scraper#1059RinZ27 wants to merge 1 commit into
RinZ27 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthened the
isPrivateHostcheck to include the AWS/GCP/Azure metadata IP (169.254.169.254) and other loopback/unspecified addresses (0.0.0.0,::). This ensures that the OG scraper cannot be used to probe sensitive cloud metadata or internal services.Switched the
fetchcall toredirect: 'manual'to prevent automated redirect bypasses. The implementation now manually validates the redirect location against the private host blocklist before following it, providing a more robust defense against SSRF attempts.Added a
Content-Typecheck to ensure the scraper only processestext/html. This prevents the server from attempting to download and process large binary files, reducing potential resource exhaustion during scraping operations.Refactored the HTML metadata extraction into a reusable
processHtmlhelper to maintain clean logic across the new redirect handling flow. All existing functionality for Open Graph and Twitter tags remains intact.