feat(toolbar): add font family combobox#3692
Conversation
Agent docs auditFound deterministic findings on 2 changed agent-doc item(s).
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e52e9bc60
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
📖 Docs preview: https://superdoc-caio-pizzol-font-family-combobox.mintlify.app |
…ly-combobox # Conflicts: # tests/behavior/tests/toolbar/font-dropdown-document-options.spec.ts
Adds an editable font family combobox to the built-in toolbar so users can type a font name, accept autocomplete with Tab or Enter, and move through the flow from font family to font size back into the editor.
Also fixes the editor input path used after toolbar-preserved selections. When typing over a visually preserved selection, SuperDoc now uses the preserved selection once, keeps ProseMirror native inline mark inheritance, and clears the preserved selection so replacement text keeps the chosen font and size without materializing style-derived marks.
Custom UI support is updated too: font-size picker options are now available through ui.fonts.getSizeOptions(), state.fonts.sizeOptions, and useSuperDocFontSizeOptions(). Docs and the configurable-toolbar example show the recommended path: use command state for current values, ui.toolbar.execute(...) for interactive toolbar mutations, and editor.doc.format.apply(...) for explicit target edits.
Commit structure:
Review:
Verified: