docs: update Angular integration examples for modern APIs#2781
Open
ArturQuirino wants to merge 1 commit intosuperdoc-dev:mainfrom
Open
docs: update Angular integration examples for modern APIs#2781ArturQuirino wants to merge 1 commit intosuperdoc-dev:mainfrom
ArturQuirino wants to merge 1 commit intosuperdoc-dev:mainfrom
Conversation
…ut and viewChild signals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Angular integration docs so examples follow current Angular patterns: signal-based
viewChild/input()and teardown withinject(DestroyRef)instead of@ViewChild,@Input(), andngOnDestroy.What changed
viewChild.required,AfterViewInit, andinject(DestroyRef).onDestroy()forsuperdoc.destroy(); SuperDoc is created inngAfterViewInitso the template ref exists.input.required()/input()for inputs; sameviewChild+DestroyRefpattern; document and user read viathis.document()/this.user().viewChild+DestroyRefcleanup; selector usesthis.editorRef().nativeElement.Why
Keeps the Getting Started Angular page aligned with modern Angular and copy-pasteable for recent projects.
Test plan
pnpm run check:importspnpm run dev:docs— verify Angular Integration page renders and snippets look correct