fix(layout): lay out all header/footer variants in per-section path (SD-2500)#2759
Open
caio-pizzol wants to merge 2 commits intomainfrom
Open
Conversation
…SD-2500) layoutWithPerSectionConstraints only measured the default header variant per section, ignoring first/even/odd. When titlePg was enabled and the decoration provider resolved the first-page rId, it wasn't in layoutsByRId so the cover page header (with branding images) never rendered. Replace resolveDefaultRIdPerSection with buildEffectiveRefsBySection to collect all variant rIds, then iterate and lay out each one with section-appropriate constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
layoutWithPerSectionConstraintsonly measured the default header variant per section, ignoring first/even/odd. WhentitlePgwas enabled and the decoration provider resolved the first-page rId, it wasn't inlayoutsByRId— so the cover page header with branding images never rendered.resolveDefaultRIdPerSectionwithbuildEffectiveRefsBySectionto collect all variant rIds per section (with OOXML inheritance)resolveDefaultRIdPerSectionFixes SD-2500. Affects Patriot, M3, and Heffernan — any doc where section 1 has
titlePg=truewith a branded first-page header.