Skip to content

feat(math): implement m:limUpp upper-limit converter#2746

Open
Abdeltoto wants to merge 2 commits intosuperdoc-dev:mainfrom
Abdeltoto:feat/math-upper-limit-converter
Open

feat(math): implement m:limUpp upper-limit converter#2746
Abdeltoto wants to merge 2 commits intosuperdoc-dev:mainfrom
Abdeltoto:feat/math-upper-limit-converter

Conversation

@Abdeltoto
Copy link
Copy Markdown

Closes #2600

Summary

  • Implements the \m:limUpp\ OMML-to-MathML converter (upper limit)
  • Maps \m:limUpp\ to MathML <mover>\ with base and limit as <mrow>\ children
  • Registers the converter in \MATH_OBJECT_REGISTRY\
  • Adds 2 unit tests covering standard usage and missing limit

Spec reference

ECMA-376 Section 22.1.2.56

Test plan

  • \�itest run\ passes for omml-to-mathml.test.ts
  • Linter and formatter pass (lefthook pre-commit)

Made with Cursor

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b494a3e8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Untitled Outdated
@@ -0,0 +1,84 @@
feat: implement m:rad radical/sqrt OMML to MathML converter
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove accidentally committed review transcript file

Untitled contains a pasted GitHub PR/review transcript unrelated to this m:limUpp change (it references a different m:rad PR), so it appears to be an accidental artifact rather than source or test data. Keeping this file at repo root adds irrelevant content to the codebase and release source archives, and makes future maintenance/searches noisier; it should be removed from the commit.

Useful? React with 👍 / 👎.

@caio-pizzol caio-pizzol self-assigned this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Math: implement m:limUpp upper limit converter (community)

2 participants