Fix upstream theme version to v2.5.0#315
Merged
Merged
Conversation
v2.5.1 removes vendored bootstrap-iso css which we require.
dyfer
approved these changes
Jul 16, 2026
dyfer
left a comment
dyfer
left a comment
Member
There was a problem hiding this comment.
I read through the issue... but I'm not very familiar with jekyll ecosystem.
So is the hope that this gets fixed upstream in sylhare/type-on-strap, or something else?
Contributor
Author
|
No, probably we have to adjust our theme downstream at some point. Maybe we just worked around some features of the theme at some point, so I don't know how much fixing this would require. I pinged the theme author for a migration path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.5.1 of our Type-On-Strap removes vendored bootstrap-iso css, which breaks the tabs functionality of the downloads page.
Re-introducing bootstrap 4.1.3 via a cdn breaks the dark theme though...
For a quick fix now, we can just stay below 2.5.1 for now - it is probably a good idea to keep this on a fixed version nonetheless, as otherwise each deployment can break the website.
For further details see #314
Please do not apply any kind of dependabot on the theme until #314 gets fixed!