Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the AMI build workflow can still terminate EC2 resources during cleanup by re-configuring AWS credentials right before cleanup runs (even on failure/cancellation).
Changes:
- Added an
aws-actions/configure-aws-credentialsstep (withif: always()) immediately before cleanup inami-release-nix.yml. - Updated
ansible/vars.ymlPostgres release strings to include a-cleanup-1suffix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ansible/vars.yml |
Adds -cleanup-1 suffixes to postgres_release values (currently violates CI merge requirements). |
.github/workflows/ami-release-nix.yml |
Re-assumes DEV_AWS_ROLE in us-east-1 before cleanup so EC2 termination can succeed after other role assumptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hunleyd
approved these changes
Mar 24, 2026
samrose
force-pushed
the
sam/cleanup-fix
branch
from
a35f046 to
1554a69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a configure-aws-credentials step before both cleanup steps that
re-assumes DEV_AWS_ROLE in us-east-1 the same role, action version (v4.3.1),
and region used by the original aws-creds step at line 51 that has EC2
permissions. It uses if:
${{ always() }}so it runs even onfailure/cancellation, matching the cleanup steps it precedes.