fix: cover the old default value 1.6 (same as 1.6.4) with empty migration#1790
Open
samrose wants to merge 17 commits into
Open
fix: cover the old default value 1.6 (same as 1.6.4) with empty migration#1790samrose wants to merge 17 commits into
samrose wants to merge 17 commits into
Conversation
Collaborator
Author
|
working on testing this now |
samrose
force-pushed
the
sam/pg-cron-migration-fix
branch
from
ce5ae76 to
9d04a34
Compare
samrose
force-pushed
the
sam/pg-cron-migration-fix
branch
from
9d04a34 to
0251ba0
Compare
PostgreSQL Extension Dependency Analysis: PR #1790
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #1790
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
za-arthur
approved these changes
Jun 5, 2026
za-arthur
reviewed
Jun 5, 2026
|
@samrose — appreciate you jumping back on this one. Wanted to flag a complementary spot while you've got #1790 open, since it's adjacent to what you're doing here. Tracing through the latest push ( The adjacent spot that sits downstream of that — the pg_cron drop/recreate in HAS_PG_CRON_OWNED_BY_POSTGRES=$(run_sql -A -t -c "select count(*) > 0 from pg_extension where extname = 'pg_cron' and extowner::regrole::text = 'postgres';")
if [ "$HAS_PG_CRON_OWNED_BY_POSTGRES" = "t" ]; then
# drop extension pg_cron; create extension pg_cron schema pg_catalog; ... (rebuilds at the bundled version)
fiDuring an in-place upgrade, HAS_PG_CRON=$(run_sql -A -t -c "select count(*) > 0 from pg_extension where extname = 'pg_cron';")
if [ "$HAS_PG_CRON" = "t" ]; then(The block already runs |
Collaborator
Author
|
related customer issue supabase/supabase#46669 (comment) |
samrose
force-pushed
the
sam/pg-cron-migration-fix
branch
from
a496d29 to
8f2f8d6
Compare
Collaborator
Author
|
working on e2e tests do not merge yet |
Collaborator
Author
pg_cron upgrade-alias coverage: deployed fleet vs. what the test exercisesScopeThis is strictly about the extension version-upgrade step not failing: every extversion string a live project can report must successfully run The deployed fleetA query of active projects by
Four of the five are legacy short-form strings that Why these legacy strings exist
Postgres builds its version graph from filenames, so these aliases are real, traversable edges. They are what let a How the test covers every deployed version
Pass 1, per-script coverage (lib.py:247-251): for every reachable edge Pass 2, full upgrade to latest (lib.py:253-258): for every reachable version Mapping the fleet to the test:
Every deployed version is an explicit, asserted test case. Why
|
applying suggestion Co-authored-by: Artur Zakirov <zaartur@gmail.com>
…lib/apt/lists itself
samrose
force-pushed
the
sam/pg-cron-migration-fix
branch
from
b16468e to
7502254
Compare
|
Found 50 test failures on Blacksmith runners: Failures
|
samrose
force-pushed
the
sam/pg-cron-migration-fix
branch
from
7502254 to
fbadad3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, the build scripts from pg_cron extension had output migrations patterned like 1.5-1.6 etc
recently we rewrote the packages to support multiple versions, and in the process did not have coverage for this form of extension version.
This adds an empty migration from 1.6 - 1.6.4 to cover where people have the previous version signature.