fix(cli): add hidden --exclude and --ignore-health-check flags to status#5770
Open
Coly010 wants to merge 1 commit into
Open
Conversation
Go's status command registers two hidden flags, --exclude and --ignore-health-check (cmd/status.go:39-42), that the TS proxy never declared. Since the Effect CLI parser rejects undeclared flags before proxying to the Go binary, supabase status --exclude db (or --ignore-health-check) failed with UnrecognizedOption in TS while working in Go. Fixes CLI-1857
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17ed12c200
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@17ed12c200dc16c8bb716a1dd63d6ebcff207b6bPreview package for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The TS
statuscommand only declares--override-name. Go'sstatusalso registers two hidden flags,--excludeand--ignore-health-check(cmd/status.go:38-42). Because the Effect CLI parser rejects undeclared flags before the command proxies to the Go binary,supabase status --exclude dbandsupabase status --ignore-health-checkfail with an UnrecognizedOption error in TS while working fine in Go.Expected Behavior
Both flags are now declared as hidden (matching Go's
MarkHidden) and forwarded verbatim to the Go binary proxy, following the same pattern already used for--override-nameand forstart's hidden flags.SIDE_EFFECTS.mddocuments the new flags with references to the Go source lines they mirror.Fixes CLI-1857