small fix + bump to pyproject.toml ver. for bug fixed release on pypi#927
Open
small fix + bump to pyproject.toml ver. for bug fixed release on pypi#927
Conversation
siddharthal
reviewed
Apr 3, 2026
Collaborator
siddharthal
left a comment
There was a problem hiding this comment.
Actually, neither of these are correct. The correct approach is this -- For each test sample, you should add the non-conformity score to the calibration list of non-conformity scores, and query percentile on this set (i.e total set size = N+1; N for calibration samples and 1 test sample). np.ceil makes more sense after you do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a bug fix to the quantile calculation in the conformal prediction set base code, along with version bumps in the project configuration files to reflect the update.
Bug fix:
_query_quantileinpyhealth/calib/predictionset/base_conformal/__init__.pyfrom usingnp.ceiltonp.floorto correct the method for selecting the quantile index, ensuring proper coverage in conformal prediction sets.Project configuration:
2.0.0to2.0.1inpyproject.tomlto reflect the bug fix.pixi-build-pythonbackend version from2.0.0to2.0.1inpyproject.tomlfor consistency with the project version.