Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions .github/workflows/codegen-check.yml

This file was deleted.

2 changes: 0 additions & 2 deletions .github/workflows/example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v6
with:
submodules: recursive
- name: Install uv with python
uses: astral-sh/setup-uv@v7
with:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v6
with:
submodules: recursive
- name: Set up Python
uses: actions/setup-python@v6
with:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ruff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v6
with:
submodules: recursive
- uses: prefix-dev/setup-pixi@v0.9.4
with:
pixi-version: v0.62.2
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v6
with:
submodules: recursive
- name: Install uv with python
uses: astral-sh/setup-uv@v7
with:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/version-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@v6
with:
submodules: recursive

- name: Install uv with python
uses: astral-sh/setup-uv@v7
Expand Down
3 changes: 0 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
[submodule "third_party/substrait"]
path = third_party/substrait
url = https://github.com/substrait-io/substrait
43 changes: 1 addition & 42 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## Get the repo
Fork and clone the repo.
```
git clone --recursive https://github.com/<your-fork>/substrait-python.git
git clone https://github.com/<your-fork>/substrait-python.git
cd substrait-python
```

Expand All @@ -12,47 +12,6 @@ Activate environment with uv.
uv sync --extra test
```

## Update the substrait submodule locally
You can run update-submodule task to pull in latest substrait from upstream.
```
pixi run update-submodule <version>
```

Or you can update submodule and run code generation at the same time with
```
pixi run update-substrait
```

This might be necessary if you are updating an existing checkout.
```
git submodule sync --recursive
git submodule update --init --recursive
```

# Code generation

You can run the full code generation using the following command or use the individual commands to selectively regenerate the generated code. This does not update the Substrait Git submodule. You can use pixi environment defined in pyproject.toml which contains all dependencies needed for code generation.

```
pixi run codegen
```

## Extension Copying

Copy the core function extensions into substrait-python

```
pixi run copy-extensions
```

## Extensions stubs

Substrait uses jsonschema to describe the data model for extension files.

```
pixi run codegen-extensions
```

# Lint & Format

Run the following pixi tasks to lint and format with ruff.
Expand Down
11 changes: 0 additions & 11 deletions check_codegen.sh

This file was deleted.

8 changes: 7 additions & 1 deletion check_substrait_package_versions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,16 @@ set -euo pipefail
# Check that all substrait-* packages have the same version
uv sync

protobuf_version=$(uv pip show substrait-protobuf | grep '^Version:' | awk '{print $2}')
antlr_version=$(uv pip show substrait-antlr | grep '^Version:' | awk '{print $2}')
extension_version=$(uv pip show vbarua-substrait-extensions | grep '^Version:' | awk '{print $2}')
protobuf_version=$(uv pip show substrait-protobuf | grep '^Version:' | awk '{print $2}')

if [ "$protobuf_version" != "$antlr_version" ]; then
echo "error: substrait-protobuf ($protobuf_version) and substrait-antlr ($antlr_version) versions do not match"
exit 1
fi

if [ "$protobuf_version" != "$extension_version" ]; then
echo "error: substrait-protobuf ($protobuf_version) and substrait-extension ($extension_version) versions do not match"
exit 1
fi
16 changes: 0 additions & 16 deletions copy_extension_yamls.sh

This file was deleted.

Loading